feat(linter): support env and globals in overrides configuration#8915
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 9, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8915 will not alter performanceComparing Summary
|
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
3 times, most recently
from
53aa4f7 to
12beab8
Compare
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
2 times, most recently
from
6b81a59 to
da5fdd4
Compare
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
2 times, most recently
from
a30a177 to
e5fe2a0
Compare
Sysix
changed the base branch from
main
to
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
from
e5fe2a0 to
4c309f2
Compare
Sysix
force-pushed
the
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
branch
from
7b10cad to
5d5278d
Compare
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
from
4c309f2 to
403a65e
Compare
Boshen
changed the base branch from
02-07-fix_linter_no-global-assign_look_for_globals_entry_too
to
graphite-base/8915
Boshen
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
from
403a65e to
b71faf1
Compare
Boshen
force-pushed
the
graphite-base/8915
branch
from
5d5278d to
b191390
Compare
Boshen
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
from
b71faf1 to
a495142
Compare
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
2 times, most recently
from
39436fa to
0f3cbea
Compare
Sysix
changed the title
env and globals in overrides configurationenv and globals in overrides configuration
camchenry
approved these changes
Feb 9, 2025
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
❤️
some small test suggestions, but feel free to merge and address later as you see fit
Sysix
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
from
0f3cbea to
4957d56
Compare
Member
Merge activity
|
#8915) This PR supports `env` and `globals` keys in `overrides[x]`. I added tests where I could. Snapshot CLI tests are working 🥳
graphite-app
bot
force-pushed
the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
from
4957d56 to
5d508a4
Compare
graphite-app
bot
deleted the
02-05-feat_linter_allow_env_and_globals_in_overrides_configuration
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
#8915) This PR supports `env` and `globals` keys in `overrides[x]`. I added tests where I could. Snapshot CLI tests are working 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports
envandglobalskeys inoverrides[x].I added tests where I could. Snapshot CLI tests are working 🥳