refactor(data_structures)!: rename Stack::last_unchecked_mut method#8911
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 5, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #8911 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Feb 5, 2025
Member
Merge activity
|
…#8911) Rename `Stack::last_mut_unchecked` to `Stack::last_unchecked_mut`. This matches `std`'s naming convention e.g. `get_unchecked_mut` on slices.
graphite-app
bot
force-pushed
the
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
branch
from
39b0c9c to
0a74cf5
Compare
graphite-app
bot
force-pushed
the
02-05-refactor_data_structures_rename_stack_last_unchecked_mut_method
branch
from
bd08016 to
bec8fee
Compare
Base automatically changed from
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
to
main
February 5, 2025 16:22
graphite-app
bot
deleted the
02-05-refactor_data_structures_rename_stack_last_unchecked_mut_method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
Stack::last_mut_uncheckedtoStack::last_unchecked_mut. This matchesstd's naming convention e.g.get_unchecked_muton slices.