refactor(ast): generated Serialize impls flatten struct fields#8904
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 5, 2025
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8904 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-05-refactor_ast_generated_serialize_impls_flatten_struct_fields
branch
from
d1daacd to
e28fccf
Compare
Dunqing
approved these changes
Feb 5, 2025
Member
Merge activity
|
In generated `impl Serialize` for AST types, flatten the fields of `Span` directly in the `serialize` method.
Before:
```rs
self.span.serialize(serde::__private::ser::FlatMapSerializer(&mut map))?;
```
After:
```rs
map.serialize_entry("start", &self.span.start)?;
map.serialize_entry("end", &self.span.end)?;
```
Serde's derive macro can't do this, because it only knows about the type it's deriving the impl for, so it has no idea what the fields of `Span` are. But `oxc_ast_tools` knows the entire AST, so it can use that information.
I doubt this will have a runtime perf impact, but it may help compile times.
Also, shorten generated code for `Serialize` impls on enums.
graphite-app
bot
force-pushed
the
02-05-refactor_ast_generated_serialize_impls_flatten_struct_fields
branch
from
e28fccf to
cbb4e9c
Compare
graphite-app
bot
deleted the
02-05-refactor_ast_generated_serialize_impls_flatten_struct_fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In generated
impl Serializefor AST types, flatten the fields ofSpandirectly in theserializemethod.Before:
After:
Serde's derive macro can't do this, because it only knows about the type it's deriving the impl for, so it has no idea what the fields of
Spanare. Butoxc_ast_toolsknows the entire AST, so it can use that information.I doubt this will have a runtime perf impact, but it may help compile times.
Also, shorten generated code for
Serializeimpls on enums.