Skip to content

docs(ast): do not include r# prefix in doc comments for AstBuilder methods#8873

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-docs_ast_do_not_include_r_prefix_in_doc_comments_for_astbuilder_methods
Feb 3, 2025
Merged

docs(ast): do not include r# prefix in doc comments for AstBuilder methods#8873
graphite-app[bot] merged 1 commit intomainfrom
02-03-docs_ast_do_not_include_r_prefix_in_doc_comments_for_astbuilder_methods

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2025

Don't include r# in field names in doc comments on AstBuilder methods.

Copy link
Member Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-docs Category - Documentation. Related to user-facing or internal documentation labels Feb 3, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 18:21
@overlookmotel
Copy link
Member Author

Only involves minor changes to doc, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 3, 2025
Copy link
Member Author

overlookmotel commented Feb 3, 2025

Merge activity

  • Feb 3, 1:26 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 1:26 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 3, 1:34 PM EST: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8873 will not alter performance

Comparing 02-03-docs_ast_do_not_include_r_prefix_in_doc_comments_for_astbuilder_methods (705208b) with main (d6d13dd)

Summary

✅ 33 untouched benchmarks

…` methods (#8873)

Don't include `r#` in field names in doc comments on `AstBuilder` methods.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_make_generated_code_consistent branch from ed765e7 to 6d1e1d8 Compare February 3, 2025 18:27
@graphite-app graphite-app bot requested a review from leaysgur as a code owner February 3, 2025 18:27
@graphite-app graphite-app bot force-pushed the 02-03-docs_ast_do_not_include_r_prefix_in_doc_comments_for_astbuilder_methods branch from 24554c2 to 705208b Compare February 3, 2025 18:27
Base automatically changed from 02-03-refactor_ast_make_generated_code_consistent to main February 3, 2025 18:32
@graphite-app graphite-app bot merged commit 705208b into main Feb 3, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-03-docs_ast_do_not_include_r_prefix_in_doc_comments_for_astbuilder_methods branch February 3, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant