Skip to content

feat(minifier): minimize !!(boolean_expr) -> boolean_expr#8849

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-03-feat_minifier_minimize_boolean_expr_-_boolean_expr_
Feb 3, 2025
Merged

feat(minifier): minimize !!(boolean_expr) -> boolean_expr#8849
graphite-app[bot] merged 1 commit intomainfrom
02-03-feat_minifier_minimize_boolean_expr_-_boolean_expr_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Feb 3, 2025

No description provided.

Copy link
Member Author

Boshen commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Feb 3, 2025
@Boshen Boshen changed the base branch from 02-03-feat_minifier_for_var_x_-_for_var_x_ to graphite-base/8849 February 3, 2025 07:58
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 3, 2025

Merge activity

  • Feb 3, 2:59 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 3, 3:04 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Feb 3, 8:14 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 8:37 AM EST: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8849 will create unknown performance changes

Comparing 02-03-feat_minifier_minimize_boolean_expr_-boolean_expr (d6d13dd) with main (4cabc16)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 24.8 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 723.9 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.6 µs N/A
🆕 lexer[antd.js] N/A 22 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.7 s N/A
🆕 mangler[antd.js] N/A 16.2 ms N/A
🆕 mangler[react.development.js] N/A 298.1 µs N/A
🆕 mangler[typescript.js] N/A 40 ms N/A
🆕 minifier[antd.js] N/A 157.2 ms N/A
🆕 minifier[react.development.js] N/A 1.5 ms N/A
🆕 minifier[typescript.js] N/A 269 ms N/A
🆕 estree[checker.ts] N/A 207.3 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.5 µs N/A
🆕 parser[antd.js] N/A 106.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@graphite-app graphite-app bot changed the base branch from graphite-base/8849 to main February 3, 2025 08:03
@Boshen Boshen force-pushed the 02-03-feat_minifier_minimize_boolean_expr_-_boolean_expr_ branch from cd41a26 to 982166a Compare February 3, 2025 13:10
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 3, 2025
@graphite-app graphite-app bot force-pushed the 02-03-feat_minifier_minimize_boolean_expr_-_boolean_expr_ branch from 982166a to d6d13dd Compare February 3, 2025 13:29
@graphite-app graphite-app bot merged commit d6d13dd into main Feb 3, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_minifier_minimize_boolean_expr_-_boolean_expr_ branch February 3, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant