Skip to content

fix(codegen): Emit this parameters of class methods#8834

Merged
Boshen merged 1 commit intooxc-project:mainfrom
MichaelMitchell-at:2025-02-01-fix_codegen_emit_this_parameters_of_class_methods
Feb 2, 2025
Merged

fix(codegen): Emit this parameters of class methods#8834
Boshen merged 1 commit intooxc-project:mainfrom
MichaelMitchell-at:2025-02-01-fix_codegen_emit_this_parameters_of_class_methods

Conversation

@MichaelMitchell-at
Copy link
Contributor

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations C-bug Category - Bug labels Feb 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 2, 2025

CodSpeed Performance Report

Merging #8834 will not alter performance

Comparing MichaelMitchell-at:2025-02-01-fix_codegen_emit_this_parameters_of_class_methods (8bfac83) with main (8a4988d)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen self-requested a review February 2, 2025 07:06
@Boshen Boshen merged commit 0928a19 into oxc-project:main Feb 2, 2025
26 checks passed
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants