refactor(codegen): accept SymbolTable instead of Mangler#8829
Merged
Boshen merged 1 commit intooxc-project:mainfrom Feb 2, 2025
Merged
refactor(codegen): accept SymbolTable instead of Mangler#8829Boshen merged 1 commit intooxc-project:mainfrom
Boshen merged 1 commit intooxc-project:mainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Boshen
approved these changes
Feb 2, 2025
CodSpeed Performance ReportMerging #8829 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to be that the easiest way to rename variables is to use rename_symbol from SymbolTable and to let it be applied during codegen - this is what Mangler does.
This PR changes Codegen to accept (any) SymbolTable instead of just Mangler itself, and for Mangler build output to be a new SymbolTable, after consuming itself (which makes it clear at the type level if a Mangler has been built or not).
This also moves the few symbol table helper methods from Mangler to SymbolTable itself, and adds an example of Mangler use to it's documentation.
Codegen dependencies now include semantic (which was transient by mangler before). It's dependency on Mangler could be removed, though I've left it to allow easy linking of docs (with_symbol_table points users to Mangler, hopefully helps with migration?)