Skip to content

docs(ast): add docs for all span fields for JS/TS nodes#8828

Closed
camchenry wants to merge 1 commit into02-01-docs_ast_add_allow_missing_docs_to_all_remaining_fields_for_js_ts_nodesfrom
02-01-docs_ast_add_docs_for_all_span_fields_for_js_ts_nodes
Closed

docs(ast): add docs for all span fields for JS/TS nodes#8828
camchenry wants to merge 1 commit into02-01-docs_ast_add_allow_missing_docs_to_all_remaining_fields_for_js_ts_nodesfrom
02-01-docs_ast_add_docs_for_all_span_fields_for_js_ts_nodes

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Feb 1, 2025

Adds a documentation comment for all span fields in JS/TS nodes. This uses a shared markdown file so that we can easily update this across all structs in the future.

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Feb 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 1, 2025

CodSpeed Performance Report

Merging #8828 will not alter performance

Comparing 02-01-docs_ast_add_docs_for_all_span_fields_for_js_ts_nodes (ee9f444) with 02-01-docs_ast_add_allow_missing_docs_to_all_remaining_fields_for_js_ts_nodes (52eb944)

Summary

✅ 33 untouched benchmarks

@camchenry camchenry marked this pull request as ready for review February 1, 2025 19:26
@camchenry camchenry force-pushed the 02-01-docs_ast_add_allow_missing_docs_to_all_remaining_fields_for_js_ts_nodes branch from fa47337 to 52eb944 Compare February 1, 2025 20:42
@camchenry camchenry force-pushed the 02-01-docs_ast_add_docs_for_all_span_fields_for_js_ts_nodes branch from cff8911 to ee9f444 Compare February 1, 2025 20:42
@Boshen Boshen closed this Feb 3, 2025
@Boshen Boshen deleted the 02-01-docs_ast_add_docs_for_all_span_fields_for_js_ts_nodes branch May 8, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants