feat(minifier): merge expressions in for-in statement head#8811
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 31, 2025
Merged
Conversation
github-actions
bot
added
A-minifier
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 31, 2025
sapphi-red
force-pushed
the
01-31-feat_minifier_merge_expressions_in_for-in_statement_head
branch
from
de38ca3 to
486f86e
Compare
CodSpeed Performance ReportMerging #8811 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
graphite-app
bot
added
0-merge
Compress `a; for (var b in c) d` into `for (var b in a, c) d`. This is possible when the left hand does not have a sideeffectful initializer. (Initializers on the left hand of for-in is Annex B thing.) **References** - [Spec of `ForIn/OfHeadEvaluation`](https://tc39.es/ecma262/multipage/ecmascript-language-statements-and-declarations.html#sec-runtime-semantics-forinofheadevaluation): `c` in the example above is passed as `expr` to this abstract operation. No side effect exists before Step 3. - [Spec of the initializer in ForIn](https://tc39.es/ecma262/multipage/additional-ecmascript-features-for-web-browsers.html#sec-initializers-in-forin-statement-heads): See "The runtime semantics of ForInOfLoopEvaluation in 14.7.5.5 are augmented with the following:" part. Evaluation of Initializer is executed before `ForIn/OfHeadEvalution`. This is the reason why it cannot be compressed when a sideeffectful initializer exists.
graphite-app
bot
force-pushed
the
01-31-feat_minifier_merge_expressions_in_for-in_statement_head
branch
from
486f86e to
d9f1d0d
Compare
graphite-app
bot
deleted the
01-31-feat_minifier_merge_expressions_in_for-in_statement_head
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compress
a; for (var b in c) dintofor (var b in a, c) d. This is possible when the left hand does not have a sideeffectful initializer. (Initializers on the left hand of for-in is Annex B thing.)References
ForIn/OfHeadEvaluation:cin the example above is passed asexprto this abstract operation. No side effect exists before Step 3.ForIn/OfHeadEvalution. This is the reason why it cannot be compressed when a sideeffectful initializer exists.