feat(minifier): complete MangleIf

[Boshen]

No description provided.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #8810 will not alter performance

_{Comparing 01-31-feat_minifier_complete_mangleif_ (9429b26) with main (d553318)}

Summary

✅ 33 untouched benchmarks

[Boshen]

There's probably a bunch of missed minifications for if (foo) statement vs if (foo) { statement }, but this is a good starting point.

[Boshen]

Failed many idempotency tests in monitor-oxc :-/

[sapphi-red]

Maybe because self.mark_current_function_as_changed is only called in some code paths?

[Boshen]

Maybe because self.mark_current_function_as_changed is only called in some code paths?

Related to ambiguous if else (dangling else)

function K(G, X, B) {
  var U, Z = iK[G];
  if (U = typeof Z == "string" ? Z : X === 1 ? Z.one : Z.other.replace("{{count}}", X.toString()), B != null && B.addSuffix)
    if (B.comparison && B.comparison > 0) return "in " + U;
  else return U + " ago";
  return U;
}

and leaving behind 1 in if (true) instead of if(!0)

if (true){
    var __func = function(){return HERE;};
} else {
    var __func = function (){return THERE;};
};

[Boshen]

@sapphi-red I had a long day today so I'll stop here, feel free to continue on this PR if you want.

We need to rework try_fold_if in remove_dead_code.rs (remove duplicated logic), and implement https://github.com/evanw/esbuild/blob/745abd9f0c06f73ca40fbe198546a9bc36c23b81/internal/js_parser/js_parser.go#L9896-L9902

I haven't fully understood how esbuild works around the dangling else problem in the minifier, but just in case you missed ... it adds the block in codegen

oxc/crates/oxc_codegen/src/gen.rs

Line 293 in 3abf2f7

stmt if wrap_to_avoid_ambiguous_else(stmt) => {

and I added wrap_to_avoid_ambiguous_else to work around the missed minification.

[sapphi-red]

I'll be stopping in a hour or so as well, so probably only going to add some comments in this PR.

[sapphi-red]

Pushed a commit that fixes monitor-oxc expect for the following one that is also failing in main branch

node_modules/.pnpm\ts-morph@25.0.0\node_modules\ts-morph\dist\ts-morph.js
-               if (currentChar === "\n" || currentChar !== " " && currentChar !== "    ") return pos + 1;
+               if (currentChar === "\n") return pos + 1;
+               if (currentChar !== " " && currentChar !== "    ") return pos + 1;

[sapphi-red]

• feat(minifier): complete MangleIf #8810 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Boshen]

Merge activity

• Feb 2, 4:05 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Feb 2, 4:05 AM EST: A user added this pull request to the Graphite merge queue.