Skip to content

docs(ast): add more docs for JS expressions, declarations, and module AST types#8800

Merged
Boshen merged 1 commit intomainfrom
01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types
Jan 31, 2025
Merged

docs(ast): add more docs for JS expressions, declarations, and module AST types#8800
Boshen merged 1 commit intomainfrom
01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Jan 31, 2025

Tried to add documentation and examples for as many of the remaining AST methods as I could. There are still around 30 or so remaining in this file, but this PR adds around 50 documentation comments.

I tried my best to check that each comment is correct, but I was inferring from the source and usage, so it may not be 100% accurate. Please take a quick look over the comments and see if it looks right.

@github-actions github-actions bot added the A-ast Area - AST label Jan 31, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Jan 31, 2025
@camchenry camchenry changed the title docs(ast): add more docs for expressions, declarations, and module AST types docs(ast): add more docs for JS expressions, declarations, and module AST types Jan 31, 2025
@camchenry camchenry force-pushed the 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types branch from 7f5d951 to eda05c5 Compare January 31, 2025 03:12
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #8800 will not alter performance

Comparing 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types (963c507) with main (45648e7)

Summary

✅ 33 untouched benchmarks

@camchenry camchenry force-pushed the 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types branch from eda05c5 to 2d06d1c Compare January 31, 2025 03:20
@camchenry camchenry marked this pull request as ready for review January 31, 2025 03:20
@camchenry camchenry requested a review from Boshen January 31, 2025 03:39
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2025
Copy link
Member

Boshen commented Jan 31, 2025

Merge activity

  • Jan 30, 10:45 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 30, 10:45 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 31, 4:06 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.

graphite-app bot pushed a commit that referenced this pull request Jan 31, 2025
… AST types (#8800)

Tried to add documentation and examples for as many of the remaining AST methods as I could. There are still around 30 or so remaining in this file, but this PR adds around 50 documentation comments.

I tried my best to check that each comment is correct, but I was inferring from the source and usage, so it may not be 100% accurate. Please take a quick look over the comments and see if it looks right.
@graphite-app graphite-app bot force-pushed the 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types branch from 2d06d1c to 823aeb2 Compare January 31, 2025 03:46
graphite-app bot pushed a commit that referenced this pull request Jan 31, 2025
… AST types (#8800)

Tried to add documentation and examples for as many of the remaining AST methods as I could. There are still around 30 or so remaining in this file, but this PR adds around 50 documentation comments.

I tried my best to check that each comment is correct, but I was inferring from the source and usage, so it may not be 100% accurate. Please take a quick look over the comments and see if it looks right.
@graphite-app graphite-app bot force-pushed the 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types branch from 823aeb2 to f452176 Compare January 31, 2025 03:48
… AST types (#8800)

Tried to add documentation and examples for as many of the remaining AST methods as I could. There are still around 30 or so remaining in this file, but this PR adds around 50 documentation comments.

I tried my best to check that each comment is correct, but I was inferring from the source and usage, so it may not be 100% accurate. Please take a quick look over the comments and see if it looks right.
@graphite-app graphite-app bot force-pushed the 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types branch from f452176 to 963c507 Compare January 31, 2025 03:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2025
@Boshen Boshen merged commit c63291a into main Jan 31, 2025
27 checks passed
@Boshen Boshen deleted the 01-30-docs_ast_add_more_docs_for_expressions_declarations_and_module_ast_types branch January 31, 2025 04:24
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants