Skip to content

refactor(ast): alter comments in generated Visit trait#8793

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-30-refactor_ast_alter_comments_in_generated_visit_trait
Jan 30, 2025
Merged

refactor(ast): alter comments in generated Visit trait#8793
graphite-app[bot] merged 1 commit intomainfrom
01-30-refactor_ast_alter_comments_in_generated_visit_trait

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 30, 2025

Make these comments more descriptive.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 30, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review January 30, 2025 22:13
@overlookmotel
Copy link
Member Author

Only alters comments, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 30, 2025
Copy link
Member Author

overlookmotel commented Jan 30, 2025

Merge activity

  • Jan 30, 5:14 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 30, 5:16 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 30, 5:21 PM EST: A user merged this pull request with the Graphite merge queue.

Make these comments more descriptive.
@graphite-app graphite-app bot force-pushed the 01-30-refactor_ast_alter_comments_in_generated_visit_trait branch from cb91fa4 to beeda9a Compare January 30, 2025 22:16
@graphite-app graphite-app bot merged commit beeda9a into main Jan 30, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-30-refactor_ast_alter_comments_in_generated_visit_trait branch January 30, 2025 22:21
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #8793 will not alter performance

Comparing 01-30-refactor_ast_alter_comments_in_generated_visit_trait (beeda9a) with main (6c627df)

Summary

✅ 33 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant