Skip to content

feat(minifier): compress array of string literals to 'str1,str2'.split(',')#8786

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-30-feat_minifier_compress_array_of_string_literals_to_str1_str2_.split_
Jan 31, 2025
Merged

feat(minifier): compress array of string literals to 'str1,str2'.split(',')#8786
graphite-app[bot] merged 1 commit intomainfrom
01-30-feat_minifier_compress_array_of_string_literals_to_str1_str2_.split_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 30, 2025

Ported ["str1", "str2", ...] => "str1 str2".split(" ") compression from closure compiler with some tweaks.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 30, 2025
@sapphi-red sapphi-red marked this pull request as ready for review January 30, 2025 10:57
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #8786 will not alter performance

Comparing 01-30-feat_minifier_compress_array_of_string_literals_to_str1_str2_.split_ (7ea99f4) with main (45648e7)

Summary

✅ 33 untouched benchmarks

@sapphi-red sapphi-red force-pushed the 01-30-feat_minifier_compress_array_of_string_literals_to_str1_str2_.split_ branch 2 times, most recently from 2c1f4e5 to dfaa586 Compare January 30, 2025 11:27
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2025
Copy link
Member

Boshen commented Jan 31, 2025

Merge activity

  • Jan 30, 10:50 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 30, 10:50 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 30, 11:20 PM EST: A user merged this pull request with the Graphite merge queue.

…it(',')` (#8786)

Ported `["str1", "str2", ...]` => `"str1 str2".split(" ")` compression from closure compiler with some tweaks.
@graphite-app graphite-app bot force-pushed the 01-30-feat_minifier_compress_array_of_string_literals_to_str1_str2_.split_ branch from c537963 to 7ea99f4 Compare January 31, 2025 04:13
@graphite-app graphite-app bot merged commit 7ea99f4 into main Jan 31, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-30-feat_minifier_compress_array_of_string_literals_to_str1_str2_.split_ branch January 31, 2025 04:20
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants