feat(minifier): implement variadic Math methods in known methods

[7086cmd]

No description provided.

[7086cmd]

• feat(minifier): implement variadic Math methods in known methods #8783 👈 (View in Graphite)
• feat(minifier): implement unary Math functions in known methods #8781
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8783 will not alter performance

_{Comparing 01-30-feat_minifier_implement_variadic_math_methods_in_known_methods (48fb1e0) with main (4f30a17)}

Summary

✅ 33 untouched benchmarks

[7086cmd]

It is intriguing that the application passes on my Mac but fails in Ubuntu. What happens?

[sapphi-red]

Maybe this issue is related: rust-lang/rust#83984

[7086cmd]

Maybe this issue is related: rust-lang/rust#83984

So we may skip minifying this at present when -0 exists, or throw a warning here? It seems to be tricky.

[sapphi-red]

Maybe this issue is related: rust-lang/rust#83984

So we may skip minifying this at present when -0 exists, or throw a warning here? It seems to be tricky.

Can we solve this by changing the result to be -0 if and only if the input includes -0 and the result was 0? If not, I think we can skip minifying for now. FYI to match -0, the comparision needs to be value == 0.0 && value.is_negative() IIRC.

[7086cmd]

Can we solve this by changing the result to be -0 if and only if the input includes -0 and the result was 0? If not, I think we can skip minifying for now. FYI to match -0, the comparision needs to be value == 0.0 && value.is_negative() IIRC.

It seems that the inelegant approach that manually comparing instead of using min or max methods works.

[7086cmd]

rust-lang/rust#91079

The std is implementing a API apart from min or max that is designed for distinguishing -0.0 and 0.0, but at present, the manually approach may be mandatory.

[Boshen]

Merge activity

• Jan 30, 10:51 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 30, 10:51 PM EST: A user added this pull request to the Graphite merge queue.
• Jan 31, 4:40 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.