refactor(ast): rename #[estree(type)] attr on types to #[estree(rename)]#8766
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2025
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8766 will not alter performanceComparing Summary
|
Member
Author
|
I'm revamping |
Member
Author
Merge activity
|
…name)]` (#8766) To rename a type in ESTree AST, use `#[estree(rename = "Identifier")]` instead of `#[estree(type = "Identifier")]`. This aligns with `serde`'s attribute, and avoids using the keyword `type`, which makes the attributes simpler to parse.
overlookmotel
force-pushed
the
01-28-refactor_ast_rename_estree_type_attr_on_types_to_estree_rename_
branch
from
acdaaa8 to
a316b10
Compare
graphite-app
bot
deleted the
01-28-refactor_ast_rename_estree_type_attr_on_types_to_estree_rename_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To rename a type in ESTree AST, use
#[estree(rename = "Identifier")]instead of#[estree(type = "Identifier")].This aligns with
serde's attribute, and avoids using the keywordtype, which makes the attributes simpler to parse.