Skip to content

feat(minifier): support a[0] and this.a in has_no_side_effect_for_evaluation_same_target#8748

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_
Jan 27, 2025
Merged

feat(minifier): support a[0] and this.a in has_no_side_effect_for_evaluation_same_target#8748
graphite-app[bot] merged 1 commit intomainfrom
01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 27, 2025

Add support for a[0] and this.a in has_no_side_effect_for_evaluation_same_target function.

Copy link
Member Author

sapphi-red commented Jan 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 27, 2025
@sapphi-red sapphi-red marked this pull request as ready for review January 27, 2025 10:35
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #8748 will not alter performance

Comparing 01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_ (3c1c92c) with main (0fcff20)

Summary

✅ 33 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 27, 2025

Merge activity

…r_evaluation_same_target` (#8748)

Add support for `a[0]` and `this.a` in `has_no_side_effect_for_evaluation_same_target` function.
@Boshen Boshen force-pushed the 01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_ branch from 8a64c58 to 3c1c92c Compare January 27, 2025 14:31
@graphite-app graphite-app bot merged commit 3c1c92c into main Jan 27, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-27-feat_minifier_support_a_0_and_this.a_in_has_no_side_effect_for_evaluation_same_target_ branch January 27, 2025 14:38
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant