perf(manger): Revert "perf(manger): remove useless tmp_bindings (#8735)"#8741
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 27, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8741 will improve performances by 4.05%Comparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
01-27-revert_perf_manger_remove_useless_tmp_bindings_8735_
branch
from
abd3297 to
937d576
Compare
Dunqing
changed the title
github-actions
bot
added
the
C-performance
Member
Merge activity
|
…" (#8741) #8735 removes `tmp_bindings` and then calls `Iterator::sorted_unstabled` instead, I thought it ideal but after I saw performance regression, I looked at `sorted_unstabled`'s implementation, and it will cause an allocation every run, but `tmp_bindings` only allocate once, then clear and reuse it in that loop.
Boshen
force-pushed
the
01-27-revert_perf_manger_remove_useless_tmp_bindings_8735_
branch
from
937d576 to
2e4ff91
Compare
graphite-app
bot
deleted the
01-27-revert_perf_manger_remove_useless_tmp_bindings_8735_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8735 removes
tmp_bindingsand then callsIterator::sorted_unstabledinstead, I thought it ideal but after I saw performance regression, I looked atsorted_unstabled's implementation, and it will cause an allocation every run, buttmp_bindingsonly allocate once, then clear and reuse it in that loop.