feat(minifier): evaluate `Math.sqrt` and `Math.cbrt` by sapphi-red · Pull Request #8731 · oxc-project/oxc

sapphi-red · 2025-01-26T10:19:36Z

Replaces Math.sqrt(a) and Math.cbrt(a) when a is a constant and the result is an integer.
The motivation of this PR is to add a comment that Math.sqrt / Math.cbrt cannot be replaced to **, rather than the actual minification improvement.

Reference

sapphi-red · 2025-01-26T10:19:47Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Boshen · 2025-01-26T10:44:53Z

Merge activity

Jan 26, 5:44 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 26, 5:44 AM EST: A user added this pull request to the Graphite merge queue.
Jan 26, 5:53 AM EST: The Graphite merge queue removed this pull request due to downstack failures on PR #8729.
Jan 26, 5:55 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 26, 6:31 AM EST: A user added this pull request to the Graphite merge queue.
Jan 26, 6:35 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
Jan 26, 7:14 AM EST: A user added this pull request to the Graphite merge queue.
Jan 26, 7:19 AM EST: A user merged this pull request with the Graphite merge queue.

codspeed-hq · 2025-01-26T10:47:57Z

CodSpeed Performance Report

Merging #8731 will not alter performance

_{Comparing 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ (9e32f55) with main (360d49e)}

Summary

✅ 33 untouched benchmarks

Replaces `Math.sqrt(a)` and `Math.cbrt(a)` when a is a constant and the result is an integer. The motivation of this PR is to add a comment that `Math.sqrt` / `Math.cbrt` cannot be replaced to `**`, rather than the actual minification improvement. **Reference** - [Spec of `Math.sqrt`](https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-math.sqrt) - [Spec of `Math.cbrt`](https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-math.cbrt) - [Spec of `Number::exponentiate`](https://tc39.es/ecma262/multipage/ecmascript-data-types-and-values.html#sec-numeric-types-number-exponentiate)

## [0.48.1] - 2025-01-26 ### Features - b7f13e6 ast: Implement utf8 to utf16 span converter (#8687) (Boshen) - 6589c3b mangler: Reuse variable names (#8562) (翠 / green) - 29bd215 minifier: Minimize `Infinity.toString(radix)` to `'Infinity'` (#8732) (Boshen) - e0117db minifier: Replace `const` with `let` for non-exported read-only variables (#8733) (sapphi-red) - 9e32f55 minifier: Evaluate `Math.sqrt` and `Math.cbrt` (#8731) (sapphi-red) - 360d49e minifier: Replace `Math.pow` with `**` (#8730) (sapphi-red) - 2e9a560 minifier: `NaN.toString(radix)` is always `NaN` (#8727) (Boshen) - cbe0e82 minifier: Minimize `foo(...[])` -> `foo()` (#8726) (Boshen) - e9fb5fe minifier: Dce pure expressions such as `new Map()` (#8725) (Boshen) ### Bug Fixes - 0944758 codegen: Remove parens from `new (import(''), function() {})` (#8707) (Boshen) - 33de70a mangler: Handle cases where a var is declared in a block scope (#8706) (翠 / green) - d982cdb minifier: `Unknown.fromCharCode` should not be treated as `String.fromCharCode` (#8709) (sapphi-red) - e7ab96c transformer/jsx: Incorrect `isStaticChildren` argument for `Fragment` with multiple children (#8713) (Dunqing) - 3e509e1 transformer/typescript: Enum merging when same name declared in outer scope (#8691) (branchseer) ### Performance - dc0b0f2 manger: Remove useless `tmp_bindings` (#8735) (Dunqing) - e472ced mangler: Optimize handling of collecting lived scope ids (#8724) (Dunqing) - 8587965 minifier: Normalize `undefined` to `void 0` before everything else (#8699) (Boshen) ### Refactor - 58002e2 ecmascript: Remove the lifetime annotation on `MayHaveSideEffects` (#8717) (Boshen) - 10e5920 linter: Move finishing default diagnostic message to `GraphicalReporter` (#8683) (Sysix) - 52a37d0 mangler: Simplify initialization of `slots` (#8734) (Dunqing) - 6bc906c minifier: Allow mutating arguments in methods called from `try_fold_known_string_methods` (#8729) (sapphi-red) - bf8be23 minifier: Use `Ctx` (#8716) (Boshen) - 0af0267 minifier: Side effect detection needs symbols resolution (#8715) (Boshen) - 32e0e47 minifier: Clean up `Normalize` (#8700) (Boshen) - c792068 semantic: Simplify `ScopeTree::iter_bindings` (#8723) (Dunqing) ### Testing - 03229c5 minifier: Fix broken tests (#8722) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

sapphi-red mentioned this pull request Jan 26, 2025

refactor(minifier): allow mutating arguments in methods called from try_fold_known_string_methods #8729

Merged

sapphi-red mentioned this pull request Jan 26, 2025

feat(minifier): replace Math.pow with ** #8730

Merged

github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 26, 2025

sapphi-red force-pushed the 01-25-feat_minifier_replace_math.pow_with_ branch from 5d8ec60 to 82a21ad Compare January 26, 2025 10:24

sapphi-red force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from 0f7b472 to 9556f95 Compare January 26, 2025 10:24

sapphi-red marked this pull request as ready for review January 26, 2025 10:32

Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 26, 2025

sapphi-red mentioned this pull request Jan 26, 2025

feat(minifier): replace const with let for non-exported read-only variables #8733

Merged

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 26, 2025

Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 26, 2025

sapphi-red force-pushed the 01-25-feat_minifier_replace_math.pow_with_ branch from 82a21ad to cbeda1b Compare January 26, 2025 11:08

sapphi-red force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from 9556f95 to 3378661 Compare January 26, 2025 11:08

sapphi-red force-pushed the 01-25-feat_minifier_replace_math.pow_with_ branch from cbeda1b to 672d6e9 Compare January 26, 2025 11:11

sapphi-red force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from 3378661 to 899d108 Compare January 26, 2025 11:12

Boshen force-pushed the 01-25-feat_minifier_replace_math.pow_with_ branch from 672d6e9 to 335d07e Compare January 26, 2025 11:18

Boshen force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from 899d108 to 2f3b1d4 Compare January 26, 2025 11:18

sapphi-red force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from 2f3b1d4 to ad8ec4a Compare January 26, 2025 11:21

Boshen changed the base branch from 01-25-feat_minifier_replace_math.pow_with_ to graphite-base/8731 January 26, 2025 11:24

graphite-app bot changed the base branch from graphite-base/8731 to main January 26, 2025 11:34

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 26, 2025

sapphi-red force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from ad8ec4a to dda3b76 Compare January 26, 2025 12:08

sapphi-red force-pushed the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch from dda3b76 to 9e32f55 Compare January 26, 2025 12:14

graphite-app bot merged commit 9e32f55 into main Jan 26, 2025
25 checks passed

graphite-app bot deleted the 01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_ branch January 26, 2025 12:19

oxc-bot mentioned this pull request Jan 26, 2025

release(crates): v0.48.1 #8738

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(minifier): evaluate `Math.sqrt` and `Math.cbrt`#8731

feat(minifier): evaluate `Math.sqrt` and `Math.cbrt`#8731
graphite-app[bot] merged 1 commit intomainfrom
01-26-feat_minifier_evaluate_math.sqrt_and_math.cbrt_

sapphi-red commented Jan 26, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Jan 26, 2025 •

edited

Loading

Uh oh!

Boshen commented Jan 26, 2025 •

edited by graphite-app bot

Loading

Uh oh!

codspeed-hq bot commented Jan 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sapphi-red commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Boshen commented Jan 26, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codspeed-hq bot commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8731 will not alter performance

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sapphi-red commented Jan 26, 2025 •

edited

Loading

sapphi-red commented Jan 26, 2025 •

edited

Loading

Boshen commented Jan 26, 2025 •

edited by graphite-app bot

Loading

codspeed-hq bot commented Jan 26, 2025 •

edited

Loading