Skip to content

fix(minifier): keep esm in dce #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 23, 2025
Merged

fix(minifier): keep esm in dce #8677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/oxc_minifier/src/peephole/remove_dead_code.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ impl<'a, 'b> PeepholeOptimizations {
if i - 1 <= index {
return true;
}
// keep function declaration
if matches!(s.as_declaration(), Some(Declaration::FunctionDeclaration(_))) {
// Keep module syntax and function declaration
if s.is_module_declaration()
|| matches!(s.as_declaration(), Some(Declaration::FunctionDeclaration(_)))
{
return true;
}
false
Expand Down Expand Up @@ -812,4 +814,10 @@ mod test {
test("!1", "");
test("1", "");
}

#[test]
fn keep_module_syntax() {
test_same("throw foo; export let bar");
test_same("throw foo; export default bar");
}
}
Loading