Skip to content

refactor(span): remove unnecessary lifetimes on Atom impls #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 21, 2025
Merged

refactor(span): remove unnecessary lifetimes on Atom impls #8639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions crates/oxc_span/src/atom.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,16 +119,16 @@ impl<'a> From<Atom<'a>> for &'a str {
}
}

impl<'a> From<Atom<'a>> for CompactStr {
impl From<Atom<'_>> for CompactStr {
#[inline]
fn from(val: Atom<'a>) -> Self {
fn from(val: Atom<'_>) -> Self {
val.into_compact_str()
}
}

impl<'a> From<Atom<'a>> for String {
impl From<Atom<'_>> for String {
#[inline]
fn from(val: Atom<'a>) -> Self {
fn from(val: Atom<'_>) -> Self {
val.into_string()
}
}
Expand Down Expand Up @@ -166,8 +166,8 @@ impl<T: AsRef<str>> PartialEq<T> for Atom<'_> {
}
}

impl<'a> PartialEq<Atom<'a>> for &str {
fn eq(&self, other: &Atom<'a>) -> bool {
impl PartialEq<Atom<'_>> for &str {
fn eq(&self, other: &Atom<'_>) -> bool {
*self == other.as_str()
}
}
Expand All @@ -178,14 +178,14 @@ impl PartialEq<str> for Atom<'_> {
}
}

impl<'a> PartialEq<Atom<'a>> for Cow<'_, str> {
fn eq(&self, other: &Atom<'a>) -> bool {
impl PartialEq<Atom<'_>> for Cow<'_, str> {
fn eq(&self, other: &Atom<'_>) -> bool {
self.as_ref() == other.as_str()
}
}

impl<'a> PartialEq<&Atom<'a>> for Cow<'_, str> {
fn eq(&self, other: &&Atom<'a>) -> bool {
impl PartialEq<&Atom<'_>> for Cow<'_, str> {
fn eq(&self, other: &&Atom<'_>) -> bool {
self.as_ref() == other.as_str()
}
}
Expand Down
Loading