Skip to content

fix(minifier): avoid minifing String(a) into "" + a for symbols #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Jan 20, 2025
Merged

fix(minifier): avoid minifing String(a) into "" + a for symbols #8612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a1a77
fix(minifier): avoid minifing `String(a)` into `"" + a` for symbols
sapphi-red Jan 20, 2025
cecdf30
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,9 +866,7 @@ impl<'a, 'b> PeepholeSubstituteAlternateSyntax {
None => Some(ctx.ast.expression_string_literal(span, "", None)),
// `String(a)` -> `'' + (a)`
Some(arg) => {
if !matches!(arg, Expression::Identifier(_) | Expression::CallExpression(_))
&& !arg.is_literal()
{
if !arg.is_literal() {
return None;
}
Some(ctx.ast.expression_binary(
Expand Down Expand Up @@ -1973,6 +1971,8 @@ mod test {
// Don't fold the existence check to preserve behavior
test_same("var a = String?.('hello')");

test_same("var s = Symbol();var a = String(s);");

test_same("var a = String('hello', bar());");
test_same("var a = String({valueOf: function() { return 1; }});");
}
Expand Down
10 changes: 5 additions & 5 deletions tasks/minsize/minsize.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ Original | minified | minified | gzip | gzip | Fixture

287.63 kB | 90.08 kB | 90.07 kB | 32.03 kB | 31.95 kB | jquery.js

342.15 kB | 118.14 kB | 118.14 kB | 44.45 kB | 44.37 kB | vue.js
342.15 kB | 118.19 kB | 118.14 kB | 44.45 kB | 44.37 kB | vue.js

544.10 kB | 71.76 kB | 72.48 kB | 26.15 kB | 26.20 kB | lodash.js

555.77 kB | 272.90 kB | 270.13 kB | 90.90 kB | 90.80 kB | d3.js

1.01 MB | 460.15 kB | 458.89 kB | 126.77 kB | 126.71 kB | bundle.min.js
1.01 MB | 460.18 kB | 458.89 kB | 126.78 kB | 126.71 kB | bundle.min.js

1.25 MB | 652.88 kB | 646.76 kB | 163.54 kB | 163.73 kB | three.js
1.25 MB | 652.90 kB | 646.76 kB | 163.54 kB | 163.73 kB | three.js

2.14 MB | 724.05 kB | 724.14 kB | 179.94 kB | 181.07 kB | victory.js
2.14 MB | 724.06 kB | 724.14 kB | 179.94 kB | 181.07 kB | victory.js

3.20 MB | 1.01 MB | 1.01 MB | 332.01 kB | 331.56 kB | echarts.js

6.69 MB | 2.31 MB | 2.31 MB | 492.51 kB | 488.28 kB | antd.js
6.69 MB | 2.31 MB | 2.31 MB | 492.53 kB | 488.28 kB | antd.js

10.95 MB | 3.49 MB | 3.49 MB | 907.24 kB | 915.50 kB | typescript.js

Loading