Skip to content

refactor(codegen): remove match_member_expression #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 19, 2025
Merged

refactor(codegen): remove match_member_expression #8597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ pub trait Gen: GetSpan {
fn gen(&self, p: &mut Codegen, ctx: Context);

/// Generate code for an AST node. Alias for `gen`.
#[inline]
fn print(&self, p: &mut Codegen, ctx: Context) {
self.gen(p, ctx);
}
Expand All @@ -30,6 +31,7 @@ pub trait GenExpr: GetSpan {
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context);

/// Generate code for an expression, respecting operator precedence. Alias for `gen_expr`.
#[inline]
fn print_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) {
self.gen_expr(p, precedence, ctx);
}
Expand Down Expand Up @@ -1186,9 +1188,9 @@ impl GenExpr for Expression<'_> {
Self::StringLiteral(lit) => lit.print(p, ctx),
Self::Identifier(ident) => ident.print(p, ctx),
Self::ThisExpression(expr) => expr.print(p, ctx),
match_member_expression!(Self) => {
self.to_member_expression().print_expr(p, precedence, ctx);
}
Self::ComputedMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::StaticMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::PrivateFieldExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::CallExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::ArrayExpression(expr) => expr.print(p, ctx),
Self::ObjectExpression(expr) => expr.print_expr(p, precedence, ctx),
Expand Down Expand Up @@ -1899,9 +1901,9 @@ impl GenExpr for SimpleAssignmentTarget<'_> {
fn gen_expr(&self, p: &mut Codegen, precedence: Precedence, ctx: Context) {
match self {
Self::AssignmentTargetIdentifier(ident) => ident.print(p, ctx),
match_member_expression!(Self) => {
self.to_member_expression().print_expr(p, precedence, ctx);
}
Self::ComputedMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::StaticMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::PrivateFieldExpression(expr) => expr.print_expr(p, precedence, ctx),
Self::TSAsExpression(e) => e.print_expr(p, precedence, ctx),
Self::TSSatisfiesExpression(e) => e.print_expr(p, precedence, ctx),
Self::TSNonNullExpression(e) => e.print_expr(p, precedence, ctx),
Expand Down Expand Up @@ -2174,9 +2176,9 @@ impl GenExpr for ChainExpression<'_> {
p.wrap(precedence >= Precedence::Postfix, |p| match &self.expression {
ChainElement::CallExpression(expr) => expr.print_expr(p, precedence, ctx),
ChainElement::TSNonNullExpression(expr) => expr.print_expr(p, precedence, ctx),
match_member_expression!(ChainElement) => {
self.expression.to_member_expression().print_expr(p, precedence, ctx);
}
ChainElement::ComputedMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
ChainElement::StaticMemberExpression(expr) => expr.print_expr(p, precedence, ctx),
ChainElement::PrivateFieldExpression(expr) => expr.print_expr(p, precedence, ctx),
});
}
}
Expand Down
Loading