Skip to content

perf(lexer): set discrimant for default variant of Kind to 0 #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
overlookmotel wants to merge 1 commit into from
Closed

perf(lexer): set discrimant for default variant of Kind to 0 #8575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/oxc_parser/src/lexer/kind.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@ use std::fmt;
/// Lexer token kind
///
/// Exported for other oxc crates to use. You generally don't need to use this directly.
//
// We set discriminant for `Eof` to 0 as it's the default, so that `Token::default()`
// is a 16-byte write of all zeros. This removes one `xmm` memory read from a hot path.
#[derive(Debug, Default, Clone, Copy, Eq, PartialEq)]
#[non_exhaustive]
#[repr(u8)]
pub enum Kind {
Undetermined,
#[default]
Eof,
Eof = 0,
Undetermined,
Skip, // Whitespace, line breaks, comments
// 12.5 Hashbang Comments
HashbangComment,
Expand Down
Loading