perf(mangler): reduce hash table lookups#8558
perf(mangler): reduce hash table lookups#8558overlookmotel wants to merge 1 commit into01-17-perf_mangler_optimize_base54_functionfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
a56cdcb to
d2a510b
Compare
CodSpeed Performance ReportMerging #8558 will not alter performanceComparing Summary
|
|
Better on 2 benchmarks (+2%) but worse on 1 (-1%). Not worthwhile. |

When getting the list of symbol names for slots, pre-prepare a single hash set of all unavailable symbol names. Then in the loop which generates symbol names, only 1 hash table lookup is required for each name.