ci(lint): run clippy in release mode#8541
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 17, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
01-16-ci_lint_run_clippy_in_release_mode
branch
from
da60a47 to
70ce295
Compare
overlookmotel
changed the base branch from
main
to
01-16-refactor_transformer_class-properties_fix_lint_warning_in_release_mode
CodSpeed Performance ReportMerging #8541 will not alter performanceComparing Summary
|
Member
Merge activity
|
CI Clippy task catch lint errors which only appear in release mode (e.g. the one fixed in #8539). Add a profile for this. `cargo clippy --profile dev-no-debug-assertions` is about 35% faster than `cargo clippy --release` (and is slightly faster than plain `cargo clippy`) but catches the same problems. This slows down the Clippy CI task, but it still remains faster than running conformance, so I don't think it's likely to slow down CI overall.
Boshen
force-pushed
the
01-16-refactor_transformer_class-properties_fix_lint_warning_in_release_mode
branch
from
66bf735 to
72f425f
Compare
Boshen
force-pushed
the
01-16-ci_lint_run_clippy_in_release_mode
branch
from
70ce295 to
1d4c7a1
Compare
Base automatically changed from
01-16-refactor_transformer_class-properties_fix_lint_warning_in_release_mode
to
main
January 17, 2025 06:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Clippy task catch lint errors which only appear in release mode (e.g. the one fixed in #8539).
Add a profile for this.
cargo clippy --profile dev-no-debug-assertionsis about 35% faster thancargo clippy --release(and is slightly faster than plaincargo clippy) but catches the same problems.This slows down the Clippy CI task, but it still remains faster than running conformance, so I don't think it's likely to slow down CI overall.