Skip to content

refactor(transformer/class-properties): fix lint warning in release mode #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 17, 2025
Merged

refactor(transformer/class-properties): fix lint warning in release mode #8539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/oxc_transformer/src/es2022/class_properties/computed_key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,15 @@ impl<'a> ClassProperties<'a, '_> {
prop: &mut PropertyDefinition<'a>,
ctx: &TraverseCtx<'a>,
) {
// Exit if computed key is not an assignment (wasn't processed in 1st pass).
let PropertyKey::AssignmentExpression(assign_expr) = &prop.key else { return };
// Exit if computed key is not an assignment (wasn't processed in 1st pass)
if !matches!(&prop.key, PropertyKey::AssignmentExpression(_)) {
return;
}

// Debug checks that we're removing what we think we are
#[cfg(debug_assertions)]
{
let PropertyKey::AssignmentExpression(assign_expr) = &prop.key else { unreachable!() };
assert!(assign_expr.span.is_empty());
let AssignmentTarget::AssignmentTargetIdentifier(ident) = &assign_expr.left else {
unreachable!();
Expand Down
Loading