Skip to content

feat(minifier): enhance merge similar if stmts#8514

Closed
camc314 wants to merge 1 commit intoc/01-15-feat_minifier_merge_similar_if_stmtsfrom
c/01-15-feat_minifier_enhance_merge_similar_if_stmts
Closed

feat(minifier): enhance merge similar if stmts#8514
camc314 wants to merge 1 commit intoc/01-15-feat_minifier_merge_similar_if_stmtsfrom
c/01-15-feat_minifier_enhance_merge_similar_if_stmts

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 15, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review January 15, 2025 15:06
Copy link
Contributor Author

camc314 commented Jan 15, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 15, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #8514 will not alter performance

Comparing c/01-15-feat_minifier_enhance_merge_similar_if_stmts (85d69a8) with c/01-15-feat_minifier_merge_similar_if_stmts (934c75c)

Summary

✅ 32 untouched benchmarks

@camc314 camc314 force-pushed the c/01-15-feat_minifier_merge_similar_if_stmts branch from 934c75c to 72fa9df Compare January 15, 2025 15:32
@camc314 camc314 force-pushed the c/01-15-feat_minifier_merge_similar_if_stmts branch from 72fa9df to 62a3dac Compare January 15, 2025 15:38
@camc314 camc314 force-pushed the c/01-15-feat_minifier_enhance_merge_similar_if_stmts branch from a2906d8 to 85d69a8 Compare January 15, 2025 15:38
@camc314 camc314 mentioned this pull request Jan 15, 2025
@Boshen
Copy link
Member

Boshen commented Jan 21, 2025

I'm going to revamp the whole thing so that changes like this won't introduce performance regressions.

@Boshen Boshen closed this Jan 21, 2025
@Boshen Boshen deleted the c/01-15-feat_minifier_enhance_merge_similar_if_stmts branch May 8, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants