Skip to content

fix(minifier): do not convert while to fors in DCE#8484

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-14-fix_minifier_do_not_convert_while_to_fors_in_dce
Jan 14, 2025
Merged

fix(minifier): do not convert while to fors in DCE#8484
graphite-app[bot] merged 1 commit intomainfrom
01-14-fix_minifier_do_not_convert_while_to_fors_in_dce

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jan 14, 2025

No description provided.

Copy link
Member Author

Boshen commented Jan 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Jan 14, 2025
@Boshen Boshen changed the base branch from 01-14-feat_ast_remove_unused_and_not_useful_contenthash_ to graphite-base/8484 January 14, 2025 09:46
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 14, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #8484 will not alter performance

Comparing 01-14-fix_minifier_do_not_convert_while_to_fors_in_dce (4c6675c) with main (7eb6ccd)

Summary

✅ 32 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/8484 to main January 14, 2025 10:00
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools labels Jan 14, 2025
@Boshen Boshen force-pushed the 01-14-fix_minifier_do_not_convert_while_to_fors_in_dce branch from 35d1374 to 4c6675c Compare January 14, 2025 10:01
@graphite-app graphite-app bot merged commit 4c6675c into main Jan 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-14-fix_minifier_do_not_convert_while_to_fors_in_dce branch January 14, 2025 10:07
Boshen added a commit that referenced this pull request Jan 14, 2025
## [0.46.0] - 2025-01-14

- 7eb6ccd ast: [**BREAKING**] Remove unused and not useful `ContentHash`
(#8483) (Boshen)

### Features

- 8accfef minifier: Minify `var x; void x` -> `void 0` (#8466) (Boshen)
- 870a583 minifier: Fold `false['toString']` (#8447) (Boshen)
- 4ad695d napi/minify: Implement napi (#8478) (Boshen)
- 9d550aa span: Add `Atom::r#static` (#8479) (_Kerman)

### Bug Fixes

- 4071878 isolated-declarations: Retain `declare` declarations when they
are exported (#8477) (Dunqing)
- 7ee7634 isolated-declarations: Import statement disappears when import
binding is referenced in nested `typeof` (#8476) (Dunqing)
- 7252cb0 isolated-declarations: Unexpected error when global `Symbol`
as property key (#8475) (Dunqing)
- 4c6675c minifier: Do not convert while to fors in DCE (#8484) (Boshen)
- 1d6e84d minifier: Fix incorrect `null.toString()` and `1n.toString()`
(#8464) (Boshen)
- 25d4bf9 minifier: Remove usage of empty spans (#8462) (Boshen)
- dd64340 minifier: Keep `return undefined` in async generator function
(#8439) (Boshen)
- c444de8 transformer/arrow-functions: Transform `this` and `super`
incorrectly in async arrow function (#8435) (Dunqing)
- 270245f transformer/typescript: Correct the semantic for
TSImportEqualsDeclaration transformation (#8463) (Dunqing)
- 2a400d6 transformer/typescript: Retain TSImportEqualsDeclaration when
it is exported (Dunqing)
- ab694b0 transformer/typescript: Retain `TSImportEqualsDeclaration` in
`namespace` when its binding has been referenced or
`onlyRemoveTypeImports` is true (#8458) (Dunqing)

### Performance

- 7a8200c mangler: Allocate base54 name without heap allocation (#8472)
(Boshen)
- 31dac22 mangler: Allocate data in arena (#8471) (Boshen)
- 8fc238a minifier: Merge `Normalize` and `RemoveSyntax` pass (#8467)
(Boshen)
- 372eb09 minifier: Preallocate mangler's semantic data (#8451) (Boshen)

### Refactor

- 6e64eef codegen: Remove `match_expression!` (#8450) (Boshen)
- de5b288 span: Rename `Atom::new_const` method (#8480) (overlookmotel)
- c83ce5c transformer/typescript: Improve transforming namespace (#8459)
(Dunqing)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant