Skip to content

refactor(transformer/arrow-functions): rename method #8481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 14, 2025
Merged

refactor(transformer/arrow-functions): rename method #8481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/oxc_transformer/src/common/arrow_function_converter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ impl<'a> Traverse<'a> for ArrowFunctionConverter<'a> {
let previous = *self.arguments_needs_transform_stack.last();
self.arguments_needs_transform_stack.push(previous || arrow.r#async);

if Self::if_ancestor_of_class_property_definition_value(ctx) {
if Self::in_class_property_definition_value(ctx) {
self.this_var_stack.push(None);
self.super_methods_stack.push(FxIndexMap::default());
}
Expand All @@ -285,7 +285,7 @@ impl<'a> Traverse<'a> for ArrowFunctionConverter<'a> {
ctx: &mut TraverseCtx<'a>,
) {
if self.is_async_only() {
if Self::if_ancestor_of_class_property_definition_value(ctx) {
if Self::in_class_property_definition_value(ctx) {
let this_var = self.this_var_stack.pop();
let super_methods = self.super_methods_stack.pop();
self.insert_variable_statement_at_the_top_of_statements(
Expand Down Expand Up @@ -403,7 +403,7 @@ impl<'a> Traverse<'a> for ArrowFunctionConverter<'a> {
// TODO: If the async arrow function without `this` or `super` usage, we can skip this step.
if self.is_async_only()
&& arrow.r#async
&& Self::if_ancestor_of_class_property_definition_value(ctx)
&& Self::in_class_property_definition_value(ctx)
{
// Inside class property definition value, since async arrow function will be
// converted to a generator function by `AsyncToGenerator` plugin, ensure
Expand Down Expand Up @@ -681,9 +681,9 @@ impl<'a> ArrowFunctionConverter<'a> {
}
}

/// Check whether the ancestor is an [`Ancestor::PropertyDefinitionValue`],
/// return false if it's reached the statement.
fn if_ancestor_of_class_property_definition_value(ctx: &mut TraverseCtx<'a>) -> bool {
/// Check whether currently in a class property initializer.
/// e.g. `x` in `class C { prop = [foo(x)]; }`
fn in_class_property_definition_value(ctx: &mut TraverseCtx<'a>) -> bool {
for ancestor in ctx.ancestors() {
if ancestor.is_parent_of_statement() {
return false;
Expand Down
Loading