Skip to content

fix(codegen): source map builder panicked because it attempted to subtract with overflow in search_original_line_and_column #8185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Dec 31, 2024
Merged

fix(codegen): source map builder panicked because it attempted to subtract with overflow in search_original_line_and_column #8185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/oxc_codegen/src/sourcemap_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::{cmp::max, path::Path, sync::Arc};
use std::{path::Path, sync::Arc};

use nonmax::NonMaxU32;
use oxc_index::{Idx, IndexVec};
Expand Down Expand Up @@ -235,9 +235,7 @@ impl SourcemapBuilder {
let lines = &self.line_offset_tables.lines;
let mut idx = self.last_line_lookup as usize;

let cap = idx.saturating_sub(16);
idx = max(idx.saturating_sub(1), cap);
while idx > cap && lines[idx].byte_offset_to_start_of_line > position {
while lines[idx].byte_offset_to_start_of_line > position {
idx -= 1;
}

Expand Down
Loading