feat(minifier): minimize computed property access#8162
feat(minifier): minimize computed property access#8162sapphi-red wants to merge 1 commit intooxc-project:mainfrom
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-minifier
| test_same("a[P]"); | ||
| test_same("a[$]"); | ||
| test_same("a[p()]"); | ||
| // test_same("a['default']"); |
There was a problem hiding this comment.
Keywords seems to be not allowed for ES3, but I guess this is fine for us.
| // upper case lower half of o from phonetic extensions set. | ||
| // valid in Safari, not in Firefox, IE. | ||
| // test_same("a['\\u1d17A']"); | ||
| // Latin capital N with tilde - nice if we handled it, but for now let's | ||
| // only allow simple Latin (aka ASCII) to be converted. | ||
| // test_same("a['\\u00d1StuffAfter']"); |
There was a problem hiding this comment.
\u1d17A is invalid for ES5 (ES5 uses Unicode 3.0 and that character was introduced in Unicode 3.1) and valid for ES2015 (ES2015 uses Unicode 5.1).
\u00d1 is valid for ES3+.
CodSpeed Performance ReportMerging #8162 will not alter performanceComparing Summary
|
|
This falls under substitute alternative syntax. I'll move the code around when I get the time. |
sapphi-red
deleted the
feat/minifier-minimize-computed-property-access
branch
2 participants
Ported
ConvertToDottedPropertiespartially. The rest seems to be mostly handled by #8147.