fix(semantic): missing references when `export {}` references a type-only binding and a normal by hyf0 · Pull Request #7812 · oxc-project/oxc

hyf0 · 2024-12-12T05:01:03Z

https://playground.oxc.rs/#eNpdTzEOgzAM/AryzFAqdUHq2rlD1YklUIMihTiyTQGh/L0BBEMn31l35/MCDZTQkBfNXmRE3xbHQKzZPSsqX3mcNrZkOgfcJU+mIPmfPEIOBOUCPPh1yOzVTFAqD5iDs14PLA0FPMnc1+QOpmy8tMT9vog5BMOCnAITXkMOfCq3BajhDtMFQLleihskRUMf7HDtkkhvvW3tYU7vKpN7OBpX8xe5JkmVWuMEY4w/P71iMw==

Current:

Expected:

https://babeljs.io/repl#?browsers=&build=&builtIns=false&corejs=false&spec=false&loose=false&code_lz=MYewdgzgLgBAKiAhtAagSwKYHcAOIBOsAvDAIwBQ5UAnjhvEtAAr4g4QwkXkYAeehGAG8YNOg2RQWbCABoJqTLgKwAvkA&debug=false&forceAllTransforms=false&modules=false&shippedProposals=false&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=env%2Ctypescript&prettier=false&targets=&version=7.26.4&externalPlugins=&assumptions=%7B%7D

graphite-app · 2024-12-12T05:01:10Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

crates/oxc_semantic/src/builder.rs

codspeed-hq · 2024-12-12T05:09:39Z

CodSpeed Performance Report

Merging #7812 will not alter performance

_{Comparing hyf0:hyf_230984903 (7b92a06) with main (25bb6da)}

Summary

✅ 29 untouched benchmarks

hyf0 · 2024-12-12T06:08:49Z

All tests pass now. I handle this PR over to you, feel free to add necessary changes. @Dunqing

Dunqing · 2024-12-12T07:07:01Z

Similar to #7813, converting to draft as waiting for a solution from it

Dunqing · 2024-12-12T14:18:15Z

Just formatted comments and added two tests. Merging it, I will make a small refactor for it later.

Dunqing · 2024-12-12T14:25:48Z

Merge activity

Dec 12, 9:25 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 12, 9:33 AM EST: A user added this pull request to the Graphite merge queue.
Dec 12, 10:59 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 12, 10:59 PM EST: A user added this pull request to the Graphite merge queue.
Dec 12, 10:59 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

…t functions (#7828) Follow-on after #7812, move setting current references flags to visit functions can reduce some unnecessary upward checking

## [0.41.0] - 2024-12-13 - fb325dc ast: [**BREAKING**] `span` field must be the first element (#7821) (Boshen) - 96a26d3 ast: [**BREAKING**] Rename `is_strict` methods to `has_use_strict_directive` (#7783) (overlookmotel) ### Features - 8991f33 ast: Add `visit_span` to `Visit` and `VisitMut` (#7816) (overlookmotel) - f7900ab ast: Add `ArrowFunctionExpression::has_use_strict_directive` method (#7784) (overlookmotel) - e727ae9 transformer/class-properties: Transform super member expressions that are inside static prop initializer (#7815) (Dunqing) ### Bug Fixes - 7610dc1 parser: Parse `import source from 'mod'` (#7833) (Boshen) - 9479e2b semantic: Missing references when `export {}` references a type-only binding and a normal (#7812) (Yunfei He) - 7a83230 semantic: Missing reference when `export default` references a type alias binding (#7813) (Dunqing) - 4a3bca8 semantic: Fix identifying strict mode arrow functions (#7785) (overlookmotel) - 5b7e1ad transformer: Remove span of define value (#7811) (Hiroshi Ogawa) - 14896cb transformer/class-properties: Create temp vars in correct scope (#7824) (overlookmotel) - 25bb6da transformer/class-properties: Fix `ScopeId`s in instance prop initializers (#7823) (overlookmotel) - 65b109a transformer/class-properties: No `raw` for generated `StringLiteral` (#7825) (overlookmotel) - 2964a61 transformer/class-properties: Unwrap failed when private field expression doesn't contain optional expression in `ChainExpression` (#7798) (Dunqing) - 6fa6785 transformer/class-properties: Panic when the callee or member is `ParenthesisExpression` or TS-syntax expressions. (#7795) (Dunqing) - bb22c67 transformer/class-properties: Fix `ScopeId`s in static prop initializers (#7791) (overlookmotel) - caa57f1 transformer/class-properties: Fix scope flags in static prop initializers (#7786) (overlookmotel) ### Performance - 4448b63 codegen: Faster writing indentation (#7820) (overlookmotel) - afaaffa codegen: Fast path for `options.print_comments()` (#7806) (Boshen) ### Refactor - 0f367e5 semantic: Improve the logic of resolving references to be cleaner (#7829) (Dunqing) - 5710950 semantic: Move export-related reference flags logic to visit functions (#7828) (Dunqing) - b290ebd transformer: Handle `<CWD>` in test runner (#7799) (Dunqing) - e70deb9 transformer/class-properties: Locate instance props insertion location in separate step (#7819) (overlookmotel) - afc5f1e transformer/class-properties: De-deduplicate code (#7805) (overlookmotel) - 47a91d2 transformer/class-properties: Shorten code (#7804) (overlookmotel) - 54ef2b9 transformer/class-properties: Rename `debug_assert_expr_is_not_parenthesis_or_typescript_syntax` (#7803) (overlookmotel) - 3cdc47c transformer/class-properties: `#[inline(always)]` on `assert_expr_neither_parenthesis_nor_typescript_syntax` (#7802) (overlookmotel) ### Testing - d72c888 transformer/replace-global-defines: Remove panicking test (#7838) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

fix(transform/typescript): shoudn't strip values

1ac03c2

hyf0 requested review from Boshen and Dunqing as code owners December 12, 2024 05:01

github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Dec 12, 2024

[autofix.ci] apply automated fixes

ea42dfa

hyf0 commented Dec 12, 2024

View reviewed changes

crates/oxc_semantic/src/builder.rs Show resolved Hide resolved

hyf0 commented Dec 12, 2024

View reviewed changes

crates/oxc_semantic/src/builder.rs Show resolved Hide resolved

hyf0 mentioned this pull request Dec 12, 2024

[Bug]: Export statement combining type and value exports is ignored rolldown/rolldown#3133

Closed

Fix

bbb486a

Boshen removed their request for review December 12, 2024 05:22

Boshen assigned Dunqing Dec 12, 2024

Fix

3b275f5

Dunqing changed the title ~~fix(transform/typescript): shoudn't strip values~~ fix(transformer/typescript): shoudn't strip values Dec 12, 2024

hyf0 added 2 commits December 12, 2024 13:56

Fix

2a58aa9

Update snap

799265d

github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 12, 2024

Dunqing marked this pull request as draft December 12, 2024 07:03

Dunqing added 3 commits December 12, 2024 22:12

foramt comment

9979923

add semantic fixture test

9444536

add a test in transformer

52678a7

Dunqing force-pushed the hyf_230984903 branch from b5094d0 to 52678a7 Compare December 12, 2024 14:12

update snapshots

938b41c

Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 12, 2024

Dunqing changed the title ~~fix(transformer/typescript): shoudn't strip values~~ fix(semantic): missing references when export {} references a type-only binding and a normal Dec 12, 2024

Dunqing marked this pull request as ready for review December 12, 2024 14:25

Dunqing added 2 commits December 12, 2024 22:26

Merge remote-tracking branch 'origin/main' into hyf_230984903

9574bfa

merge main

1f77a18

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 12, 2024

Dunqing approved these changes Dec 13, 2024

View reviewed changes

Dunqing added 3 commits December 13, 2024 11:28

Merge remote-tracking branch 'origin/main' into hyf_230984903

48b353f

Merge branch 'main' into hyf_230984903

3e455e0

update snapshot

7b92a06

Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 13, 2024

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 13, 2024

Dunqing merged commit 9479e2b into oxc-project:main Dec 13, 2024

Dunqing mentioned this pull request Dec 13, 2024

refactor(semantic): move export-related reference flags logic to visit functions #7828

Merged

oxc-bot mentioned this pull request Dec 13, 2024

release(crates): v0.41.0 #7846

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(semantic): missing references when `export {}` references a type-only binding and a normal#7812

fix(semantic): missing references when `export {}` references a type-only binding and a normal#7812
Dunqing merged 15 commits intooxc-project:mainfrom
hyf0:hyf_230984903

hyf0 commented Dec 12, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 12, 2024

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Dec 12, 2024 •

edited

Loading

Uh oh!

hyf0 commented Dec 12, 2024 •

edited

Loading

Uh oh!

Dunqing commented Dec 12, 2024 •

edited

Loading

Uh oh!

Dunqing commented Dec 12, 2024

Uh oh!

Dunqing commented Dec 12, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hyf0 commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Dec 12, 2024

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #7812 will not alter performance

Summary

Uh oh!

hyf0 commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Dec 12, 2024

Uh oh!

Dunqing commented Dec 12, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hyf0 commented Dec 12, 2024 •

edited

Loading

codspeed-hq bot commented Dec 12, 2024 •

edited

Loading

hyf0 commented Dec 12, 2024 •

edited

Loading

Dunqing commented Dec 12, 2024 •

edited

Loading

Dunqing commented Dec 12, 2024 •

edited by graphite-app bot

Loading