Skip to content

feat(ast, transformer): add AstBuilder::use_strict_directive method#7770

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-10-feat_ast_add_astbuilder_use_strict_directive_method
Dec 10, 2024
Merged

feat(ast, transformer): add AstBuilder::use_strict_directive method#7770
graphite-app[bot] merged 1 commit intomainfrom
12-10-feat_ast_add_astbuilder_use_strict_directive_method

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 10, 2024

Add AstBuilder::use_strict_directive method, and use it in transformer.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Dec 10, 2024

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 10, 2024
@overlookmotel overlookmotel changed the title feat(ast): add AstBuilder::use_strict_directive method feat(ast, transformer): add AstBuilder::use_strict_directive method Dec 10, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 10, 2024 13:10
@overlookmotel
Copy link
Member Author

Small change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
Copy link
Member Author

overlookmotel commented Dec 10, 2024

Merge activity

  • Dec 10, 8:11 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 10, 8:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 8:23 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from 12-10-refactor_ast_astbuilder_extra_methods_use_span_ to graphite-base/7770 December 10, 2024 13:11
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #7770 will not alter performance

Comparing 12-10-feat_ast_add_astbuilder_use_strict_directive_method (7dcf6b4) with main (98afe65)

Summary

✅ 29 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/7770 to main December 10, 2024 13:16
…#7770)

Add `AstBuilder::use_strict_directive` method, and use it in transformer.
@overlookmotel overlookmotel force-pushed the 12-10-feat_ast_add_astbuilder_use_strict_directive_method branch from e82f3a4 to 7dcf6b4 Compare December 10, 2024 13:17
@graphite-app graphite-app bot merged commit 7dcf6b4 into main Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-10-feat_ast_add_astbuilder_use_strict_directive_method branch December 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant