Skip to content

test(transformer/class-properties): override test output for _super in class constructor#7726

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-08-test_transformer_class-properties_override_test_outputfor__super_in_class_constructor
Dec 8, 2024
Merged

test(transformer/class-properties): override test output for _super in class constructor#7726
graphite-app[bot] merged 1 commit intomainfrom
12-08-test_transformer_class-properties_override_test_outputfor__super_in_class_constructor

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 8, 2024

Our output for this test differs from Babel, because we handle super() in class constructors differently, but our output is valid.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 8, 2024
@overlookmotel overlookmotel changed the title test(transformer/class-properties): override test outputfor _super in class constructor test(transformer/class-properties): override test output for _super in class constructor Dec 8, 2024
Copy link
Member Author

@overlookmotel
Copy link
Member Author

I think I know this particular one better than anyone else, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2024
Copy link
Member Author

overlookmotel commented Dec 8, 2024

Merge activity

  • Dec 8, 10:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 8, 10:51 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 8, 10:57 AM EST: A user merged this pull request with the Graphite merge queue.

… in class constructor (#7726)

Our output for this test differs from Babel, because we handle `super()` in class constructors differently, but our output is valid.
@overlookmotel overlookmotel force-pushed the 12-08-test_transformer_class-properties_override_test_outputfor__super_in_class_constructor branch from df7cfb9 to 3bae741 Compare December 8, 2024 15:52
@graphite-app graphite-app bot merged commit 3bae741 into main Dec 8, 2024
@graphite-app graphite-app bot deleted the 12-08-test_transformer_class-properties_override_test_outputfor__super_in_class_constructor branch December 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant