feat(transformer/class-properties): support for transforming AssignmentTarget#7697
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 6, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Dunqing
changed the title
AssignmentTarget
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #7697 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Dec 6, 2024
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
Great! So many test cases now green.
Member
Merge activity
|
…entTarget` (#7697) Instance prop: * `[object.#prop] = arr` -> `[_toSetter(_classPrivateFieldSet, [_prop, object])._] = arr` * `({x: object.#prop} = obj)` -> `({ x: _toSetter(_classPrivateFieldSet, [_prop, object])._ } = obj)` Static prop: * `[object.#prop] = arr` -> `[_assertClassBrand(Class, object, _prop)._] = arr` * `({x: object.#prop} = obj)` -> `({ x: _assertClassBrand(Class, object, _prop)._ } = obj)`
overlookmotel
force-pushed
the
12-06-feat_transformer_class-properties_support_for_transforming_assignmenttarget
branch
from
ac6801b to
86d4c90
Compare
graphite-app
bot
deleted the
12-06-feat_transformer_class-properties_support_for_transforming_assignmenttarget
branch
This was referenced Dec 6, 2024
Dunqing
pushed a commit
that referenced
this pull request
Dec 6, 2024
Follow-on after #7697. No need to cast twice. You can go from `MemberExpression` direct to `AssignmentTarget`.
Dunqing
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ssignment_target` (#7701) Follow-on after #7697. `transform_assignment_target` is inlined into `enter_assignment_target` visitor, so we want it to be as small as possible. Move assigning to `target` into `transform_assignment_target_impl`, which is the cold path. The principle is that in the transformer the most important thing for performance is to optimize for the path which is "nothing to do here, exit". Here we are only transforming `object.#prop`, but very few `AssignmentTarget`s are `object.#prop`, so 99% of the time there is nothing to do. So we want to keep that "do nothing and exit" path as fast and small as possible. In practice, the `*target =` assignment is only a single assembly operation, so this PR is a micro-optimization. But why not? Every little helps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instance prop:
[object.#prop] = arr->[_toSetter(_classPrivateFieldSet2, [_prop, object])._] = arr({x: object.#prop} = obj)->({ x: _toSetter(_classPrivateFieldSet2, [_prop, object])._ } = obj)Static prop:
[object.#prop] = arr->[_assertClassBrand(Class, object, _prop)._] = arr({x: object.#prop} = obj)->({ x: _assertClassBrand(Class, object, _prop)._ } = obj)