Skip to content

fix(transformer/class-properties): create temp var for this in computed key#7686

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-04-fix_transformer_class-properties_create_temp_var_for_this_in_computed_key
Dec 6, 2024
Merged

fix(transformer/class-properties): create temp var for this in computed key#7686
graphite-app[bot] merged 1 commit intomainfrom
12-04-fix_transformer_class-properties_create_temp_var_for_this_in_computed_key

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 5, 2024

this in computed key needs a temp var, otherwise once moved into constructor it refers to the wrong this.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 5, 2024
Copy link
Member Author

overlookmotel commented Dec 5, 2024

@github-actions github-actions bot added the C-bug Category - Bug label Dec 5, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7686 will not alter performance

Comparing 12-04-fix_transformer_class-properties_create_temp_var_for_this_in_computed_key (72b5d58) with main (28ce187)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 12-04-fix_transformer_class-properties_create_temp_var_for_this_in_computed_key branch from 67fd742 to 04c1b3a Compare December 5, 2024 20:10
@overlookmotel overlookmotel marked this pull request as ready for review December 5, 2024 20:10
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 6, 2024
Copy link
Member

Dunqing commented Dec 6, 2024

Merge activity

  • Dec 5, 9:20 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 9:20 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 5, 9:20 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 5, 9:25 PM EST: A user merged this pull request with the Graphite merge queue.

…uted key (#7686)

`this` in computed key needs a temp var, otherwise once moved into constructor it refers to the wrong `this`.
@Dunqing Dunqing force-pushed the 12-04-fix_transformer_class-properties_create_temp_var_for_this_in_computed_key branch from 04c1b3a to 72b5d58 Compare December 6, 2024 02:21
@graphite-app graphite-app bot merged commit 72b5d58 into main Dec 6, 2024
@graphite-app graphite-app bot deleted the 12-04-fix_transformer_class-properties_create_temp_var_for_this_in_computed_key branch December 6, 2024 02:25
Dunqing pushed a commit that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants