Skip to content

feat(codegen): minify whitespace for some expressions#7671

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions
Dec 5, 2024
Merged

feat(codegen): minify whitespace for some expressions#7671
graphite-app[bot] merged 1 commit intomainfrom
12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 5, 2024

part of #7638

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-codegen Area - Code Generation C-enhancement Category - New feature or request labels Dec 5, 2024
Copy link
Member Author

Boshen commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen marked this pull request as draft December 5, 2024 05:58
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7671 will not alter performance

Comparing 12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions (d0b78f7) with main (6ae178e)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions branch from f7dc140 to f136027 Compare December 5, 2024 06:14
@Dunqing
Copy link
Member

Dunqing commented Dec 5, 2024

We need to figure out what expressions are required to print whitespace and what are not.

@Boshen Boshen force-pushed the 12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions branch 2 times, most recently from 6f91463 to 3d9b01c Compare December 5, 2024 06:33
@Boshen Boshen changed the title feat(codegen): minify whitespace for throw, await and import expressions feat(codegen): minify whitespace for some expressions Dec 5, 2024
@Boshen Boshen force-pushed the 12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions branch from 3d9b01c to eb12458 Compare December 5, 2024 06:49
@Boshen Boshen marked this pull request as ready for review December 5, 2024 06:58
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Merge activity

@Boshen Boshen force-pushed the 12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions branch from eb12458 to d0b78f7 Compare December 5, 2024 06:59
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@graphite-app graphite-app bot merged commit d0b78f7 into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-05-feat_codegen_minify_whitespace_for_throw_await_and_import_expressions branch December 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants