refactor(transformer/class-properties): use duplicate_object in transform_expression_to_wrap_nullish_check#7664
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 5, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Dunqing
changed the title
duplicate_object in transform_expression_to_wrap_nullish_check
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
duplicate_object in transform_expression_to_wrap_nullish_checkduplicate_object in transform_expression_to_wrap_nullish_check
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #7664 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
12-05-refactor_transformer_class-properties_use_duplicate_object_in_transform_expression_to_wrap_nullish_check
branch
from
cd04ec0 to
f787b71
Compare
overlookmotel
approved these changes
Dec 5, 2024
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
Rebased on main and made a couple of small tweaks.
Member
Merge activity
|
…ansform_expression_to_wrap_nullish_check` (#7664) The `duplicate_object` is great, it has handled unbound identifiers and `this` expressions, so we can remove a lot of code. But it is still a little bit annoying because we need two `object` here, although we can use `clone_in` it needs a special logic for `Expression::Identifier`.
overlookmotel
force-pushed
the
12-05-refactor_transformer_class-properties_use_duplicate_object_in_transform_expression_to_wrap_nullish_check
branch
from
f787b71 to
8883968
Compare
graphite-app
bot
deleted the
12-05-refactor_transformer_class-properties_use_duplicate_object_in_transform_expression_to_wrap_nullish_check
branch
Dunqing
pushed a commit
that referenced
this pull request
Dec 5, 2024
…od (#7685) Follow-up after #7664. Generalize `duplicate_object` to produce however many duplicates are required. Use it in `transform_expression_to_wrap_nullish_check`. This should be slightly more efficient, and will make it fool-proof if we expand `duplicate_object` later to handle other `Expression` types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
duplicate_objectis great, it has handled unbound identifiers andthisexpressions, so we can remove a lot of code. But it is still a little bit annoying because we need twoobjecthere, although we can useclone_init needs a special logic forExpression::Identifier.