Skip to content

fix(estree): raw: null in ESTree AST for generated BooleanLiterals#7661

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s
Dec 5, 2024
Merged

fix(estree): raw: null in ESTree AST for generated BooleanLiterals#7661
graphite-app[bot] merged 1 commit intomainfrom
12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 5, 2024

In JS-side AST, leave raw field as null for BooleanLiterals, if they are generated and have no raw representation in source text.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-ast Area - AST label Dec 5, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Dec 5, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #7661 will not alter performance

Comparing 12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s (1d59fc8) with main (8993e89)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel changed the base branch from 12-05-refactor_ast_shorten_code to graphite-base/7661 December 5, 2024 01:16
@overlookmotel overlookmotel force-pushed the 12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s branch from fe57723 to 52387be Compare December 5, 2024 01:25
@overlookmotel overlookmotel changed the base branch from graphite-base/7661 to main December 5, 2024 01:26
@overlookmotel overlookmotel force-pushed the 12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s branch from 52387be to 14136e8 Compare December 5, 2024 01:26
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Merge activity

#7661)

In JS-side AST, leave `raw` field as `null` for `BooleanLiteral`s, if they are generated and have no raw representation in source text.
@Dunqing Dunqing force-pushed the 12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s branch from 14136e8 to 1d59fc8 Compare December 5, 2024 04:01
@graphite-app graphite-app bot merged commit 1d59fc8 into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-05-fix_estree_raw_null_in_estree_ast_for_generated_booleanliteral_s branch December 5, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants