Skip to content

refactor(transformer/class-properties): move logic for handling delete of chain expression into transform_unary_expression#7655

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_
Dec 5, 2024
Merged

refactor(transformer/class-properties): move logic for handling delete of chain expression into transform_unary_expression#7655
graphite-app[bot] merged 1 commit intomainfrom
12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 4, 2024

Follow-on after #7575. Pure refactor. Move all logic for transforming delete <chain expression> into the handler transform_unary_expression. Aim is to keep logic in one place and keep the main visitor as simple as possible.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 4, 2024
Copy link
Member Author

overlookmotel commented Dec 4, 2024

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Dec 4, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 4, 2024 21:29
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7655 will create unknown performance changes

Comparing 12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_ (44fe854) with main (6c82589)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark main 12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_ Change
🆕 codegen[checker.ts] N/A 25.4 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 76.9 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 730 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24.1 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.7 s N/A
🆕 minifier[antd.js] N/A 221.6 ms N/A
🆕 minifier[react.development.js] N/A 2.1 ms N/A
🆕 minifier[typescript.js] N/A 381.6 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.8 µs N/A
🆕 parser[antd.js] N/A 107.4 ms N/A
🆕 parser[cal.com.tsx] N/A 29.7 ms N/A
🆕 parser[checker.ts] N/A 54.1 ms N/A
🆕 parser[pdf.mjs] N/A 17.5 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 74.8 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Merge activity

…te` of chain expression into `transform_unary_expression` (#7655)

Follow-on after #7575. Pure refactor. Move all logic for transforming `delete <chain expression>` into the handler `transform_unary_expression`. Aim is to keep logic in one place and keep the main visitor as simple as possible.
@Dunqing Dunqing force-pushed the 12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_ branch from 2080da3 to 44fe854 Compare December 5, 2024 01:07
@graphite-app graphite-app bot merged commit 44fe854 into main Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-04-refactor_transformer_class-properties_move_logic_for_handling_delete_of_chain_expression_into_transform_unary_expression_ branch December 5, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant