refactor(transformer/jsx): Pragma::parse take a &str#7619
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 4, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 3, 2024
CodSpeed Performance ReportMerging #7619 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
af37f57 to
6c70b6c
Compare
eb8bcdf to
171c635
Compare
`Pragma::parse` take an `Option<&str>` instead of `Option<&String>`. Passing `&String`s to functions is an odd pattern.
6c70b6c to
2158c38
Compare
171c635 to
8ad52be
Compare
Base automatically changed from
12-03-test_transformer_jsx_move_tests_setup_into_a_macro
to
main
December 4, 2024 02:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pragma::parsetake anOption<&str>instead ofOption<&String>. Passing&Strings to functions is an odd pattern.