Skip to content

feat(linter): Implement eslint:yoda #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 4 commits into from
Dec 4, 2024
Merged

feat(linter): Implement eslint:yoda #7559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb1de8f
impl eslint:yoda
tbashiyy Dec 1, 2024
38a48d0
fix diagnostic message
tbashiyy Dec 2, 2024
9b9b1d6
fix docs
tbashiyy Dec 2, 2024
ca6b24f
minor cleanup
camc314 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/oxc_ast/src/ast_impl/js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ impl<'a> ComputedMemberExpression<'a> {
{
Some(lit.quasis[0].value.raw.clone())
}
Expression::RegExpLiteral(lit) => Some(Atom::from(lit.raw)),
_ => None,
}
}
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ mod eslint {
pub mod unicode_bom;
pub mod use_isnan;
pub mod valid_typeof;
pub mod yoda;
}

mod typescript {
Expand Down Expand Up @@ -640,6 +641,7 @@ oxc_macros::declare_all_lint_rules! {
eslint::unicode_bom,
eslint::use_isnan,
eslint::valid_typeof,
eslint::yoda,
import::default,
import::export,
import::first,
Expand Down
Loading