Skip to content

feat(parser,linter)!: use a different ModuleRecord for linter#7554

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-30-feat_parser_linter_separate_modulerecord_
Nov 30, 2024
Merged

feat(parser,linter)!: use a different ModuleRecord for linter#7554
graphite-app[bot] merged 1 commit intomainfrom
11-30-feat_parser_linter_separate_modulerecord_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 30, 2024

The parser returns a simple ModuleRecord that is allocated in the arena for performance reasons.

The linter uses a more complicated, Send + Sync ModuleRecord that will hold more cross-module information.

The next step is to return more esm information from the parser to eliminated the need of the oxc_module_lexer crate.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Nov 30, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #7554 will improve performances by 33.04%

Comparing 11-30-feat_parser_linter_separate_modulerecord_ (c2ced15) with main (7e42e71)

Summary

⚡ 3 improvements
✅ 27 untouched benchmarks

Benchmarks breakdown

Benchmark main 11-30-feat_parser_linter_separate_modulerecord_ Change
isolated-declarations[vue-id.ts] 945.8 ms 710.9 ms +33.04%
parser[RadixUIAdoptionSection.jsx] 98.4 µs 87 µs +13.08%
parser[cal.com.tsx] 32.7 ms 29.1 ms +12.26%

@Boshen Boshen force-pushed the 11-30-feat_parser_linter_separate_modulerecord_ branch from c494062 to 4114497 Compare November 30, 2024 15:56
@Boshen Boshen marked this pull request as ready for review November 30, 2024 15:56
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 30, 2024
Copy link
Member Author

Boshen commented Nov 30, 2024

Merge activity

  • Nov 30, 10:56 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 30, 11:02 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 30, 11:06 AM EST: A user merged this pull request with the Graphite merge queue.

The parser returns a simple `ModuleRecord` that is allocated in the arena for performance reasons.

The linter uses a more complicated, `Send` + `Sync` `ModuleRecord` that will hold more cross-module information.

The next step is to return more esm information from the parser to eliminated the need of the `oxc_module_lexer` crate.
@Boshen Boshen force-pushed the 11-30-feat_parser_linter_separate_modulerecord_ branch from 4114497 to c2ced15 Compare November 30, 2024 16:02
@graphite-app graphite-app bot merged commit c2ced15 into main Nov 30, 2024
@graphite-app graphite-app bot deleted the 11-30-feat_parser_linter_separate_modulerecord_ branch November 30, 2024 16:06
This was referenced Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-editor Area - Editor and Language Server A-linter Area - Linter A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant