Skip to content

perf(syntax): use FxDashMap for exported bindings#7525

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-28-perf_syntax_use_fxdashmap_for_exported_bindings
Nov 28, 2024
Merged

perf(syntax): use FxDashMap for exported bindings#7525
graphite-app[bot] merged 1 commit intomainfrom
11-28-perf_syntax_use_fxdashmap_for_exported_bindings

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 28, 2024

Same as #7521. Use FxDashMap instead of plain DashMap for hash map storing exported bindings.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Nov 28, 2024

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Nov 28, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 28, 2024 11:44
@Boshen Boshen changed the base branch from 11-28-refactor_linter_syntax_introduce_type_alias_fxdashmap_ to graphite-base/7525 November 28, 2024 11:45
@Boshen Boshen force-pushed the 11-28-perf_syntax_use_fxdashmap_for_exported_bindings branch from fb116d5 to 4b1b4db Compare November 28, 2024 11:51
@Boshen Boshen force-pushed the graphite-base/7525 branch from 646e513 to 169b8bf Compare November 28, 2024 11:51
@Boshen Boshen changed the base branch from graphite-base/7525 to main November 28, 2024 11:52
@Boshen Boshen force-pushed the 11-28-perf_syntax_use_fxdashmap_for_exported_bindings branch from 4b1b4db to 675a2dd Compare November 28, 2024 11:52
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
Copy link
Member

Boshen commented Nov 28, 2024

Merge activity

  • Nov 28, 6:56 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 7:21 AM EST: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7525 will not alter performance

Comparing 11-28-perf_syntax_use_fxdashmap_for_exported_bindings (4a98230) with main (f847d0f)

Summary

✅ 30 untouched benchmarks

Same as #7521. Use `FxDashMap` instead of plain `DashMap` for hash map storing exported bindings.
@Boshen Boshen force-pushed the 11-28-perf_syntax_use_fxdashmap_for_exported_bindings branch from 675a2dd to 4a98230 Compare November 28, 2024 12:15
@graphite-app graphite-app bot merged commit 4a98230 into main Nov 28, 2024
@graphite-app graphite-app bot deleted the 11-28-perf_syntax_use_fxdashmap_for_exported_bindings branch November 28, 2024 12:21
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants