Skip to content

refactor(transformer/class-properties): correct comments #7506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 27, 2024
Merged

refactor(transformer/class-properties): correct comments #7506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions crates/oxc_transformer/src/es2022/class_properties/private.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
ctx: &mut TraverseCtx<'a>,
) {
// Unfortunately no way to make compiler see that these branches are provably unreachable.
// This function is much too large inline, because `transform_static_assignment_expression`
// and `transform_instance_assignment_expression` are inlined into it.
// This function is much too large to inline.
let Expression::CallExpression(call_expr) = expr else { unreachable!() };
let Expression::PrivateFieldExpression(field_expr) = &mut call_expr.callee else {
unreachable!()
Expand Down Expand Up @@ -229,7 +228,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
ctx: &mut TraverseCtx<'a>,
) {
// Unfortunately no way to make compiler see that these branches are provably unreachable.
// This function is much too large inline, because `transform_static_assignment_expression`
// This function is much too large to inline, because `transform_static_assignment_expression`
// and `transform_instance_assignment_expression` are inlined into it.
let Expression::AssignmentExpression(assign_expr) = expr else { unreachable!() };
let AssignmentTarget::PrivateFieldExpression(field_expr) = &mut assign_expr.left else {
Expand Down Expand Up @@ -578,8 +577,7 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
ctx: &mut TraverseCtx<'a>,
) {
// Unfortunately no way to make compiler see that these branches are provably unreachable.
// This function is much too large inline, because `transform_static_assignment_expression`
// and `transform_instance_assignment_expression` are inlined into it.
// This function is much too large to inline.
let Expression::UpdateExpression(update_expr) = expr else { unreachable!() };
let field_expr = match &mut update_expr.argument {
SimpleAssignmentTarget::PrivateFieldExpression(field_expr) => field_expr.as_mut(),
Expand Down