feat(oxc_transformer): replace_global_define for assignmentTarget#7505
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 27, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
IWANABETHATGUY
requested review from
Dunqing and
overlookmotel
as code owners
IWANABETHATGUY
changed the title
IWANABETHATGUY
force-pushed
the
11-27-feat_replace_global_define_for_assignmenttarget
branch
from
bf68f9c to
8c2c06c
Compare
IWANABETHATGUY
force-pushed
the
11-27-feat_replace_global_define_for_assignmenttarget
branch
2 times, most recently
from
ddb3eb1 to
b4a7f33
Compare
CodSpeed Performance ReportMerging #7505 will not alter performanceComparing Summary
|
Member
|
I don't know the define plugin at all. Can I please leave this to someone else to review? |
Contributor
Author
Yeah, @Boshen may have a look when he has time. |
Member
Merge activity
|
Boshen
force-pushed
the
11-27-feat_replace_global_define_for_assignmenttarget
branch
from
b4a7f33 to
60a8b9f
Compare
graphite-app
bot
deleted the
11-27-feat_replace_global_define_for_assignmenttarget
branch
Boshen
pushed a commit
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related esbuild test:
https://github.com/evanw/esbuild/blob/d34e79e2a998c21bb71d57b92b0017ca11756912/internal/bundler_tests/bundler_default_test.go#L5430-L5497