Skip to content

Comments

refactor(transformer/class-properties): safer use of GetAddress#7474

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-25-refactor_transformer_class-properties_safer_use_of_getaddress_
Nov 25, 2024
Merged

refactor(transformer/class-properties): safer use of GetAddress#7474
graphite-app[bot] merged 1 commit intomainfrom
11-25-refactor_transformer_class-properties_safer_use_of_getaddress_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 25, 2024

Avoid using Address::from_ptr, which is error-prone.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 25, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 25, 2024 12:11
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #7474 will not alter performance

Comparing 11-25-refactor_transformer_class-properties_safer_use_of_getaddress_ (25823c8) with main (3396b69)

Summary

✅ 30 untouched benchmarks

@overlookmotel
Copy link
Member Author

Currently, I think I'm the one who understands this transform best, and this is a small change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2024
Copy link
Member Author

overlookmotel commented Nov 25, 2024

Merge activity

  • Nov 25, 9:24 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 9:24 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 25, 9:32 AM EST: A user merged this pull request with the Graphite merge queue.

)

Avoid using `Address::from_ptr`, which is error-prone.
@overlookmotel overlookmotel force-pushed the 11-25-refactor_transformer_class-properties_safer_use_of_getaddress_ branch from 9532f05 to 25823c8 Compare November 25, 2024 14:25
@graphite-app graphite-app bot merged commit 25823c8 into main Nov 25, 2024
@graphite-app graphite-app bot deleted the 11-25-refactor_transformer_class-properties_safer_use_of_getaddress_ branch November 25, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant