Skip to content

Comments

feat(ast): derive GetAddress on all enum types#7472

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-25-feat_ast_derive_getaddress_on_all_enum_types
Nov 25, 2024
Merged

feat(ast): derive GetAddress on all enum types#7472
graphite-app[bot] merged 1 commit intomainfrom
11-25-feat_ast_derive_getaddress_on_all_enum_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 25, 2024

Implement GetAddress on all AST enums where all variants are boxed. Part of #7339.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools labels Nov 25, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 25, 2024
@overlookmotel overlookmotel marked this pull request as ready for review November 25, 2024 11:55
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #7472 will not alter performance

Comparing 11-25-feat_ast_derive_getaddress_on_all_enum_types (eb70219) with main (d7d0735)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2024
Copy link
Member

Boshen commented Nov 25, 2024

Merge activity

  • Nov 25, 7:12 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 7:13 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 25, 7:18 AM EST: A user merged this pull request with the Graphite merge queue.

Implement `GetAddress` on all AST enums where all variants are boxed. Part of #7339.
@Boshen Boshen force-pushed the 11-25-feat_ast_derive_getaddress_on_all_enum_types branch from 1fdabbd to eb70219 Compare November 25, 2024 12:13
@graphite-app graphite-app bot merged commit eb70219 into main Nov 25, 2024
@graphite-app graphite-app bot deleted the 11-25-feat_ast_derive_getaddress_on_all_enum_types branch November 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants