Skip to content

Comments

fix(transformer): correct all ReferenceFlags#7410

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-22-fix_transformer_correct_all_referenceflags
Nov 22, 2024
Merged

fix(transformer): correct all ReferenceFlags#7410
graphite-app[bot] merged 1 commit intomainfrom
11-22-fix_transformer_correct_all_referenceflags

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 22, 2024

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@Dunqing Dunqing marked this pull request as ready for review November 22, 2024 05:25
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 22, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Nov 22, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #7410 will not alter performance

Comparing 11-22-fix_transformer_correct_all_referenceflags (7ff9f13) with main (6f0fe38)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2024
@Boshen Boshen changed the base branch from 11-21-refactor_semantic_infer_referenceflags_from_visit_methods to graphite-base/7410 November 22, 2024 06:06
Copy link
Member

Boshen commented Nov 22, 2024

Merge activity

  • Nov 22, 1:06 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 22, 1:07 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 1:20 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Nov 22, 4:10 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 22, 4:10 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 22, 4:15 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/7410 to main November 22, 2024 06:19
@graphite-app graphite-app bot requested a review from Boshen as a code owner November 22, 2024 06:19
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic labels Nov 22, 2024
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 22, 2024
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@Boshen Boshen force-pushed the 11-22-fix_transformer_correct_all_referenceflags branch from 130a6df to 7ff9f13 Compare November 22, 2024 09:11
@graphite-app graphite-app bot merged commit 7ff9f13 into main Nov 22, 2024
@graphite-app graphite-app bot deleted the 11-22-fix_transformer_correct_all_referenceflags branch November 22, 2024 09:15
overlookmotel added a commit that referenced this pull request Nov 25, 2024
Follow-on after #7410. Update comment to reflect the changed logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants