Skip to content

Comments

fix(sourcemap): improve source map visualizer#7386

Merged
Boshen merged 12 commits intooxc-project:mainfrom
hi-ogawa:fix-sourcemap-viz-reverse
Nov 21, 2024
Merged

fix(sourcemap): improve source map visualizer#7386
Boshen merged 12 commits intooxc-project:mainfrom
hi-ogawa:fix-sourcemap-viz-reverse

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 21, 2024

Probably this is still an approximation of what https://github.com/evanw/source-map-visualization does, but I tried to get some ideas from it.

For comparison, I added an example from their site https://evanw.github.io/source-map-visualization/ as a snapshot in crates/oxc_sourcemap/tests/fixtures/esbuild/visualizer.snap. I'll mention a few notable changes in the comments.

Snapshot change in rolldown repo can be found in

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@hi-ogawa hi-ogawa changed the title fix: improve source map visualizer fix(sourcemap): improve source map visualizer Nov 21, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Nov 21, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review November 21, 2024 05:43
@Boshen
Copy link
Member

Boshen commented Nov 21, 2024

Just need to fix clippy warnings.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #7386 will not alter performance

Comparing hi-ogawa:fix-sourcemap-viz-reverse (13584ca) with main (e6922df)

Summary

✅ 30 untouched benchmarks

@hi-ogawa hi-ogawa requested a review from Boshen November 21, 2024 06:22
@Boshen Boshen merged commit 3d66929 into oxc-project:main Nov 21, 2024
@hi-ogawa hi-ogawa deleted the fix-sourcemap-viz-reverse branch November 21, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants